feat: Add GPG key fingerprint to SSH key fingerprints doc#43238
feat: Add GPG key fingerprint to SSH key fingerprints doc#43238marcelocra wants to merge 5 commits intogithub:mainfrom
Conversation
Updated the title and added GPG key information.
github-actions
bot
added
the
triage
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
Adds GPG fingerprint information alongside the existing SSH fingerprints documentation so readers can verify GitHub-related keys from a single reference page.
Changes:
- Update the article title to include GPG fingerprints
- Add separate
## SSHand## GPGsections - Add a GPG fingerprint block with a note about key rotation/expiration and retrieval locations
Comments suppressed due to low confidence (1)
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md:22
variables.product.prodname_dotcomis marked "DO NOT USE" indata/variables/product.yml(usevariables.product.githubinstead). Replace these instances to follow the repo’s variable conventions.
These are {% data variables.product.prodname_dotcom %}'s public key fingerprints:
{% data reusables.ssh.fingerprints %}
You can add the following ssh key entries to your `~/.ssh/known_hosts` file to avoid manually verifying {% data variables.product.prodname_dotcom %} hosts:
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md
Outdated
Show resolved
Hide resolved
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md
Outdated
Show resolved
Hide resolved
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md
Show resolved
Hide resolved
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
content/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints.md:23
variables.product.prodname_dotcomis explicitly marked “DO NOT USE” indata/variables/product.yml; please replace these occurrences with the appropriate variable (likelyvariables.product.githubor, if you specifically mean the github.com site,variables.product.prodname_dotcom_the_website).
These are {% data variables.product.prodname_dotcom %}'s public key fingerprints:
{% data reusables.ssh.fingerprints %}
You can add the following ssh key entries to your `~/.ssh/known_hosts` file to avoid manually verifying {% data variables.product.prodname_dotcom %} hosts:
|
@marcelocra Sorry, reading through this, is this for a feature that's being deprecated this year? |
Sharra-writes
added
content
Sharra-writes
added
more-information-needed
|
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open an issue to describe your changes. Then we can reopen this PR and begin the review process. |
Updated the title and added GPG key information.
Why:
Closes: #43237
What's being changed (if available, include any code snippets, screenshots, or gifs):
Added the GPG key fingerprint to the page.
Check off the following: